Improve package manager UX #1710
Open
+573
−535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
5 tasks
samamou
commented
Feb 7, 2025
| @@ -222,7 +246,8 @@ void PluginSettingsView::refresh() | |||
| if(qEnvironmentVariableIsSet("SCORE_SANITIZE_SKIP_CHECKS")) | |||
| return; | |||
| QNetworkRequest rqst{ | |||
| QUrl("https://raw.githubusercontent.com/ossia/score-addons/master/addons.json")}; | |||
| QUrl("https://raw.githubusercontent.com/ossia/score-addons/refs/heads/" | |||
There was a problem hiding this comment.
- TODO: Change back when this branch is merged with main
samamou
commented
Feb 11, 2025
| ps_view.remoteView()->horizontalHeader()->setStretchLastSection(true); | ||
|
|
||
| ps_view.remoteView()->setSelectionModel(&ps_model.remoteSelection); | ||
|
|
||
| // ps_view.remoteView()->setSelectionModel(&ps_model.remoteSelection); |
There was a problem hiding this comment.
need to re-enable this for the install button to work
|
Can we please check why the checks are failing so we can merge soon? @jcelerier |
jcelerier
force-pushed
the
1701-improve-package-manager-ux
branch
from
abedc99 to
c2c00cf
Compare
|
I just rebased on current master which has fully green CI so that we can see if there's any failure related to this patch specifically :) |
|
CI is green in all the places that matter :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes issue #1701