Add FreeBSD operations & facts #1246
Conversation
|
fixed! |
There was a problem hiding this comment.
Hi @DtxdF! Thank you for the PR, this looks great! Would it be possible to add some tests for the operations? (plenty of examples here: https://github.com/pyinfra-dev/pyinfra/tree/3.x/tests/operations).
| @@ -0,0 +1,12 @@ | |||
| # This file only exists to support: | |||
There was a problem hiding this comment.
I really like the use of a submodule for all the freebsd operations, neat.
Finally I have a time. I have seen the logic in both |
There's a script |
|
Nice to see this. @DtxdF, contact me if you're interested in getting this into the FreeBSD port early, or maybe even taking maintainership of the port - I'm currently lacking time to invest more into side projects like this. |
* Change `tests/test_operations.py` to accept freebsd operations - Fix `ValueError: too many values to unpack (expected 2)` * Simplify fact `freebsd.ServiceScript`. * Add missing parameter `jail` in `freebsd.pkg` operation. * Change Enum to simple "constants" in `freebsd.sysrc` and `freebsd.service` to use strings instead of the properties to make the tests work and to use those operations from the CLI. * Change the `state` argument to `srvstate` in `freebsd.service.service` to avoid conflicts with `pyinfra_cli/util.py:load_func` when invoking the operation from the CLI.
Great! I will send you a patch in Bugzilla! Thanks! |
Thank you! The tests are already with some changes, let me know if everything goes well! |
|
Are you ok with this PR or do I need to do something else? I am very anxious to migrate from Ansible to Pyinfra :D |
No description provided.