-
-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require explicit override decorator #1255
base: 3.x
Are you sure you want to change the base?
Conversation
I think this is a good change, an explicit typing improvement with no actual functionality change. Only concern might be breaking type-checking with other modules but that doesn't fall under the version compatibility anyway so probably OK... |
24740a3
to
75254cb
Compare
75254cb
to
b9fa3a9
Compare
Well, it passes the pipeline now, but locally I still get some errors:
So I'm guessing there's some different version of greenlet installed in my container ? |
They look unrelated though? Possibly greenlet related, I'll pull this and poke at it a bit when I can. |
Not sure if this is a good idea, hence a draft MR, there would be some 304 missing
@override
decorators.