facts: server.Mounts: fix whitespaces and escaped characters #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mount` command can not be parsed unambigiously. Whitespaces in paths and , in option lists are not escaped. See the new tests for examples the old code can not handle. This patch switches to reading from `/proc/self/mountinfo` instead (see man 5 proc for documentation) where strings are properly escaped. While `/proc/self/mountinfo` provides a lot more details, these are ignored to keep compatibility with the old type. If there is a need, the missing fields can be easily added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mountcommand can not be parsed unambigiously. Whitespaces in paths and,in option lists are not escaped. See the new tests for examples the old code can not handle.This patch switches to reading from
/proc/self/mountinfoinstead (see man 5 proc for documentation) where strings are properly escaped.While
/proc/self/mountinfoprovides a lot more details, these are ignored to keep compatibility with the old type. If there is a need, the missing fields can be easily added.@Fizzadar 461d8ec introduced handling "map devices". I'm not sure what they are. I'd love to see a line from
/proc/self/mountinfo, so we can test against that.