gh-131807: fix ResourceWarning in test_ucn.py #131808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
graingert
commented
Mar 27, 2025
•
graingert
commented
- Issue: ResourceWarning in test.test_ucn.UnicodeNamesTest.test_named_sequences_full (when http request 404s) #131807
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a ResourceWarning in test_ucn.py by adjusting how network resource errors are handled during URL retrieval in tests.
- Introduces an explicit import for urllib.error.
- Splits exception handling into a specific block for urllib.error.HTTPError (with an explicit resource cleanup) and a combined block for OSError and HTTPException.
- Replaces the previous cleanup approach with a context manager for test data.
Comments suppressed due to low confidence (2)
Lib/test/test_ucn.py:185
- Ensure that calling e.close() on HTTPError is valid and necessary; if HTTPError does not implement a close() method or is already handled by a context manager, this call might be redundant or could lead to unexpected behavior.
except urllib.error.HTTPError as e:
Lib/test/test_ucn.py:187
- [nitpick] Consider using a more concise error message format without variable name expansion (e.g. using '{e}' instead of '{e=}') to prevent potentially exposing internal details.
self.skipTest(f"Could not retrieve {url} {e=}")
graingert
added
needs backport to 3.12
vstinner
reviewed
Mar 28, 2025
Co-authored-by: Victor Stinner <vstinner@python.org>
|
Thanks @graingert for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit adb67ed) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-131845 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 28, 2025
(cherry picked from commit adb67ed) Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-131846 is a backport of this pull request to the 3.12 branch. |
|
Merged, thanks for the fix. |
|
vstinner
added a commit
that referenced
this pull request
Mar 28, 2025
vstinner
added a commit
that referenced
this pull request
Mar 28, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.