Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements: extended exposed latency metrics and allowed for filtering benchmark runs by client count. #101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into general.improvements
  • Loading branch information
filipecosta90 authored Jun 17, 2024
commit 366f8a2feda413a927e1fc87449c12fdac15b7e3
5 changes: 5 additions & 0 deletions engine/base_client/client.py
Original file line number Diff line number Diff line change
@@ -152,6 +152,11 @@ def run_experiment(
)
# ensure we specify the client count in the results
search_params["parallel"] = client_count
if not DETAILED_RESULTS:
# Remove verbose stats from search results
search_stats.pop("latencies", None)
search_stats.pop("precisions", None)

self.save_search_results(
dataset.config.name, search_stats, search_id, search_params
)
You are viewing a condensed version of this merge commit. You can view the full changes here.