Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picking some milvus improvements. Updated milvus client to include backoff strategy on ingestion. Added extra configurations to ease remote benchmark run. #170

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Cherry picking some milvus improvements. Updated milvus client to include backoff strategy on ingestion. Added extra configurations to ease remote benchmark run. #170

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cf6a10
Updated milvus client to include backoff strategy on ingestion. Added…
filipecosta90 Jul 19, 2024
190e0ab
Fixes per linter: ruff and isort
filipecosta90 Jul 19, 2024
b1f4941
Added backoff dependency
filipecosta90 Jul 19, 2024
6c58202
Fixes per linter: isort
filipecosta90 Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixes per linter: isort
  • Loading branch information
@filipecosta90
filipecosta90 committed Jul 19, 2024
commit 6c582027d1525021a3c39f82b3d94a45d2c5d03a
7 changes: 1 addition & 6 deletions engine/clients/milvus/configure.py
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
from pymilvus import (
Collection,
CollectionSchema,
DataType,
FieldSchema,
)
from pymilvus import Collection, CollectionSchema, DataType, FieldSchema
from pymilvus.exceptions import DataTypeNotSupportException
from pymilvus.orm import utility

6 changes: 1 addition & 5 deletions engine/clients/milvus/upload.py
View file
Original file line number Diff line number Diff line change
@@ -3,11 +3,7 @@
from typing import List

import backoff
from pymilvus import (
Collection,
MilvusException,
wait_for_index_building_complete,
)
from pymilvus import Collection, MilvusException, wait_for_index_building_complete

from dataset_reader.base_reader import Record
from engine.base_client.upload import BaseUploader