Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectCommand not implemented #14

Closed
virtuald opened this issue Nov 20, 2022 · 5 comments · Fixed by #17
Closed

SelectCommand not implemented #14

virtuald opened this issue Nov 20, 2022 · 5 comments · Fixed by #17

Comments

@virtuald
Copy link
Member

Should look at either a pure python implementation or wrap it. It was a template if I remember correctly.

@megarubber
Copy link

Is it necessary to add the SelectCommand class first in WPILib C++?

@auscompgeek
Copy link
Member

@mrguisamuel it already exists in C++. https://github.com/wpilibsuite/allwpilib/blob/main/wpilibNewCommands/src/main/native/include/frc2/command/SelectCommand.h

@megarubber
Copy link

megarubber commented Dec 19, 2022

For now, is it necessary the .cpp file or only the header?
Because the WPILibC++ has the SelectCommand example, but not in complete form, as compared to Java (I guess)

@auscompgeek
Copy link
Member

I'm not sure I understand. The C++ SelectCommand example looks to be as complete as the corresponding Java example to me.

@megarubber
Copy link

woops, my mistake... I got confused here. Sorry for this @auscompgeek 😔

I wanna convert the SelectCommand example to python, this is why I questioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants