Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.1.0 #10

Closed
jamesmunns opened this issue Mar 12, 2019 · 6 comments
Closed

Release version 0.1.0 #10

jamesmunns opened this issue Mar 12, 2019 · 6 comments

Comments

@jamesmunns
Copy link
Member

jamesmunns commented Mar 12, 2019

It looks like the release of this crate is blocked by @japaric not having crate ownership/permissions to the serde-json-core crate.

@dtolnay could you please grant Jorge permissions to the repo on crates.io so this can be released?

EDIT: Or alternatively, could you (dtolnay) please publish the current version of the crate? Though that would leave this crate in a similar version in the future.

@dtolnay
Copy link

dtolnay commented Mar 12, 2019

I added him as owner when I uploaded 0.0.1. It should be in his pending invites:
https://crates.io/me/pending-invites

@keithduncan
Copy link

I was able to work around this with a [patch] in my manifest to get this compiling on stable for the time being:

[dependencies]
serde = { version = "1.0", default-features = false, features = ["derive"] }
serde-json-core = "0.0.1"

[patch.crates-io]
serde-json-core = { git = "https://github.com/japaric/serde-json-core" }

@thejpster
Copy link
Member

Just a +1 as I fell over this one today. Thanks @keithduncan for the work-around.

@jamesmunns
Copy link
Member Author

jamesmunns commented Oct 1, 2019

Hey @japaric, would it be possible to release this?

@jamesmunns
Copy link
Member Author

jamesmunns commented Oct 25, 2019

As a heads up, I needed this for a project (where I didn't want a patch section), so I have forked the repository and released the 0.1.0 changes, as well as some 2018 edition MaybeUninit and dependency updates:

I don't hope to keep this as a permanent fork, but I know @japaric is busy in the mean time. This might be acceptable for some temporarily.

@japaric
Copy link
Collaborator

japaric commented Nov 17, 2019

@japaric japaric closed this as completed Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants