Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow forcefully setting slave address #68

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Allow forcefully setting slave address #68

merged 2 commits into from
Nov 16, 2021
+41 −1

Conversation

iamkroot
Copy link
Contributor

@iamkroot iamkroot commented Nov 15, 2021 •
edited
Loading

Closes #59

I think a few more warnings are needed in the docstrings.
Should the contents of the two new constructors be abstracted into a separate method?

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon.

Please see the contribution instructions for more information.

eldruin
eldruin reviewed Nov 15, 2021
View reviewed changes
eldruin
eldruin reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Could you also add an entry to the changelog?

@iamkroot iamkroot marked this pull request as ready for review November 16, 2021 11:42
@iamkroot iamkroot requested a review from a team as a code owner November 16, 2021 11:42
eldruin
eldruin reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small correction, looks good to me, thank you!

eldruin
eldruin approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work.
bors r+

@iamkroot
Copy link
Contributor Author

Thanks for the patient review! :)

@bors
Copy link
Contributor

bors bot commented Nov 16, 2021

Build succeeded:

@bors bors bot merged commit 1c2c672 into rust-embedded:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin

Assignees

@posborne posborne

Labels
S-waiting-on-review T-embedded-linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to force-open a device
4 participants
@iamkroot @rust-highfive @eldruin @posborne