Pass full filepath in prompt to the LLM. #7472
Merged
+252
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenamankumar
force-pushed
the
naman/pass-full-filepath-in-prompt
branch
from
9c116c8 to
ff18990
Compare
abeatrix
approved these changes
Mar 21, 2025
| version: 1, | ||
| contextItem: { | ||
| type: 'file', | ||
| uri: 'file:///foo/bar/file1.go', |
There was a problem hiding this comment.
Suggested change
| uri: 'file:///foo/bar/file1.go', | |
| uri: testFileUri('/foo/bar/file1.go'), |
i think this should fix the test on windows
thenamankumar
force-pushed
the
naman/pass-full-filepath-in-prompt
branch
from
69e2fe4 to
c28c06a
Compare
abeatrix
reviewed
Mar 24, 2025
| ) | ||
| }) | ||
| }) | ||
|
|
||
| describe('editorStateFromPromptString', () => { | ||
| test('converts to rich mentions', async () => { | ||
| const input = ps`What are @${PromptString.fromDisplayPath( | ||
| URI.file('foo.go') | ||
| )}:3-5 and @${PromptString.fromDisplayPath(URI.file('bar.go'))} about?` | ||
| testFileUri('foo.go') |
There was a problem hiding this comment.
Suggested change
| testFileUri('foo.go') | |
| displayPath(testFileUri('/foo.go')) |
if it's fromDisplayPath?
thenamankumar
force-pushed
the
naman/pass-full-filepath-in-prompt
branch
from
268ea6b to
4a7be80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://linear.app/sourcegraph/issue/CODY-5393/bug-fix-send-the-file-path-to-the-model-for-at-mentions
This PR updates the get text from editor state logic to include the full file display path and not just the file basename.
The text is sent to the LLM as the human message text.
Test plan
unit tests added.
mention a file and debug & test if the full file display path is included in the prompt.