fix: at mentions should allow more special characters #7500
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahrmichael
requested review from
a team and
thenamankumar
and removed request for
a team
| @@ -235,7 +235,7 @@ export function splitToWords(s: string): string[] { | |||
| * - "cody://tabs." -> matches "cody://tabs" | |||
| * - "cody://serialized.v1?data=123_." -> matches "cody://serialized.v1?data=123_" | |||
| */ | |||
| const pattern = /(cody:\/\/(?:serialized[^_]+_|[^_\s.]+))/ | |||
There was a problem hiding this comment.
Should the above comment be updated?
There was a problem hiding this comment.
Yup, good catch!
thenamankumar
approved these changes
Mar 25, 2025
bahrmichael
deleted the
bahrmichael/mentions-allow-more-special-characters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CODY-5443
Screen.Recording.2025-03-26.at.14.14.48.mov
Test plan
New unit tests, manual testing (see video above)