-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include the whole Spring Boot parent in your springdoc-openapi
pom
#2944
Comments
To me it looks like the release notes already include that information? We have that 2.8.4 upgraded to 3.4.2. And then the omission of a version mentioned in 2.8.5 means that we still have the same version. There also exists a weakly version-matched compatibility matrix in some dark corner of their docs. But yes this does not take away from the fact that it would be beneficial if they could be detached from each other. |
This is an invalid issue. This ticket will be closed, but can be reopened if your provide the reproducible sample. |
I'm attaching a small demo that shows how importing SpringDoc's BOM changes the version of Spring Framework, effectively breaking the app. I hope that makes this ticket more understandable for you. |
I have added <dependencyManagement>
<dependencies>
<dependency>
<groupId>org.springdoc</groupId>
<artifactId>springdoc-openapi-bom</artifactId>
<version>2.8.7-SNAPSHOT</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement> Can you validate with the latest SNAPSHOT, if it resolves your issue ? |
Hi @bnasslahsen, Unfortunately, it does not. It's still too strong, because this bom is still using I was trying to prepare a proposal, but it's not that trivial, and I have, unfortunately, other projects to attend to. Maybe I'll find the time sometime in the future. |
I have updated with a new version. |
Is your feature request related to a problem? Please describe.
We're using Maven to build our projects. We're also using
spring-boot-starter-parent
as our parent pom. Once we import yourspringdoc-openapi
with typepom
and scopeimport
, you're overwriting versions fromspring-boot-starter-parent
. We've noticed this problem today as we wanted to upgrade Spring Boot to3.4.4
, but the newest version of SpringDoc (2.8.5
) is still using Spring Boot3.4.2
.In the end, even though we were starting from Spring Boot
3.4.4
, we were getting dependencies from Spring Boot3.4.2
, which are incompatible. For example, instead of Spring Framework6.2.5
, we were getting6.2.2
.Describe the solution you'd like
Please include in your BOM only versions for JARs you're providing. Everything else should be our responsibility. Of course, it would be nice if you've kept an information in release notes that your version X is compatible with Spring Boot version Y, so that the users would know what to expect. Any deviations in versions would then be responsibility of those users.
Describe alternatives you've considered
For now I had to do two things:
spring-boot-starter-parent
as parent pom for our project, we had to import, again,spring-boot-dependencies
independencyManagement
section.springdoc-openapi
to the bottom ofdependencyManagement
so that versions of all other libraries are already set before Maven gets to SpringDoc dependencies.The text was updated successfully, but these errors were encountered: