Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL test inside PostgreSQL test class #739

Closed
uuf6429 opened this issue Jan 29, 2025 · 1 comment · Fixed by #740
Closed

MySQL test inside PostgreSQL test class #739

uuf6429 opened this issue Jan 29, 2025 · 1 comment · Fixed by #740

Comments

@uuf6429
Copy link
Contributor

uuf6429 commented Jan 29, 2025

I'm just wondering if the following method (with respect to the containing class/file) is maybe a copy & paste mistake?

phpstan-dba/tests/default/data/typemix-pgsql.php

Line 13 in 525a9fa

public function typemixMysqli(mysqli $mysqli)

At one point I thought maybe it was meant to test pg_ functions, but that driver doesn't seem to be supported at all.

I can't otherwise see any connection between postgres and mysql. 🤔
@staabm
Copy link
Owner

staabm commented Jan 30, 2025

you are right - it seems to be a copy paste mistake.

support for non-pdo-pgsql aka pg_* is welcome if you need it

@uuf6429 uuf6429 mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant test and constants uuf6429/phpstan-dba
2 participants
@staabm @uuf6429