Changed the protobuf version to 3.6.1 to accomodate latest bazel version #111
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
======================================
Coverage 90.6% 90.6%
======================================
Files 31 31
Lines 2715 2715
Branches 432 432
======================================
Hits 2460 2460
Misses 177 177
Partials 78 78Continue to review full report at Codecov.
|
|
Looks good to me, I'll merge it in. |
cweill
pushed a commit
that referenced
this pull request
Jun 4, 2019
…ion | Closes PR #111. Protobuf in the WORKSPACE has been changed and the bazel test cases are currently running fine locally. Copybara import of the project: - 0df5fc6 Changed the protobuf version to 3.6.1 to accomodate lates... by chandramouli <chanduiyer.raja@gmail.com> - 64985e0 Merge branch 'master' into master by Charles Weill <weill@google.com> - 5fed4cd Merge 64985e0 into 6eb71... by chandramoulirajagopalan <chanduiyer.raja@gmail.com> PiperOrigin-RevId: 251455788
|
Thanks for this. It's now merged in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf in the WORKSPACE has been changed and the bazel test cases are currently running fine locally. Closes #111.