-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing typo in example and changing default eval throttle_secs since … #95
Conversation
Check out this pull request on ReviewNB: https://app.reviewnb.com/tensorflow/adanet/pull/95 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 91.61% 88.91% -2.71%
==========================================
Files 30 30
Lines 2589 2589
Branches 441 441
==========================================
- Hits 2372 2302 -70
- Misses 147 213 +66
- Partials 70 74 +4
Continue to review full report at Codecov.
|
…this causes rapid re-evaluation in TF 1.9
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Updated author info on commit to pass CLA check. |
@zjost: Thanks, I'll have a look. |
…this causes rapid re-evaluation in TF 1.9
Resolving #61 . Just changing
throttle_secs
from 1 to 30 intf.estimator.EvalSpec
.