Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use local log_group throughout, fixing log configuration with Lambda@Edge. #666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theherk
Copy link

@theherk theherk commented Mar 13, 2025

Fixes #650 and #665.

Description

Motivation and Context

This allows module implementations using lambda_at_edge = true to actually log to Cloudwatch.

Breaking Changes

This will cause changes for users using lambda_at_edge = true, but is is a fixing change.

How Has This Been Tested?

  • I have verified the changes in my infrastructure.
  • I have executed pre-commit run -a on my pull request
  terraform-aws-lambda
ᐅ pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
mixed line ending........................................................Passed

@theherk theherk changed the title Use local log_group throughout, fixing log configuration with Lambda@Edge. fix: Use local log_group throughout, fixing log configuration with Lambda@Edge. Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudwatch log group for Lambda@Edge is not set correctly
1 participant