Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when upload filename has chinese characters, it throw invalid character error #687

Closed
2 tasks done
lqqyt2423 opened this issue Dec 19, 2024 · 2 comments · Fixed by #725
Closed
2 tasks done

when upload filename has chinese characters, it throw invalid character error #687

lqqyt2423 opened this issue Dec 19, 2024 · 2 comments · Fixed by #725
Labels
bug

Comments

@lqqyt2423
Copy link

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Steps to reproduce

npm run demo:azure

code line: https://github.com/tus/tus-node-server/blob/main/packages/azure-store/src/index.ts#L78

azure doc: https://learn.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#metadata-key-and-value-names

says: Metadata value names must also be valid ASCII.

Expected behavior

should upload success when filename has chinese characters.

Actual behavior

failed, throw invalid character in header content ["x-ms-meta-upload"]
@lqqyt2423 lqqyt2423 added the bug label Dec 19, 2024
@Murderlon
Copy link
Member

I suppose we'd have to store the uploading metadata in a .info file, like the other stores do, instead of on metadata which is send over headers.

@mitjap
Copy link
Collaborator

mitjap commented Feb 5, 2025

It could be just base64 encoded possibly with Metadata.stringify and Metadata.parse, requiring minimal changes.

@Murderlon Murderlon mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@tus/azure-store: fix non-ASCII characters error on metadata tus/tus-node-server
3 participants
@mitjap @lqqyt2423 @Murderlon