Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output ESM for all packages #736

Open
wants to merge 11 commits into
base: node-version
Choose a base branch
from
Open

Output ESM for all packages #736

wants to merge 11 commits into from

Conversation

Murderlon
Copy link
Member

@Murderlon Murderlon commented Mar 13, 2025

Now that we make the required Node.js version >=20.19.0 (#723), which is the specific release that stabilized require(esm), we might as well output ESM as it makes no difference anymore. We keep the same level of compatibility.

Notable changes:

  • Set "type": "module" and "exports" in all package.json's.
  • In tests, import from newly defined "exports" or from dist/ (instead of /src) if not exported.
  • Set "module": "NodeNext" in tsconfig.base.json (done in Bump required Node.js version from 16 to 20 #723, which this branch is based off).
  • Because of that option we have have to explicitly import .js extensions which is the majority of this diff.

@Murderlon Murderlon added the Breaking change This requires a semver major release label Mar 13, 2025
@Murderlon Murderlon self-assigned this Mar 13, 2025
Copy link

changeset-bot bot commented Mar 13, 2025

🦋 Changeset detected

Latest commit: 62fe21d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@tus/azure-store Major
@tus/file-store Major
@tus/gcs-store Major
@tus/s3-store Major
@tus/server Major
@tus/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Mar 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Murderlon Murderlon marked this pull request as draft March 13, 2025 16:35
@Murderlon Murderlon marked this pull request as ready for review March 24, 2025 09:54
Copy link

socket-security bot commented Mar 24, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@tus/s3-store@1.9.0, npm/ts-node@10.9.2

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change This requires a semver major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant