Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Issues #1

Open
tylermcginnis opened this issue Jul 15, 2019 · 17 comments
Open

Course Issues #1

tylermcginnis opened this issue Jul 15, 2019 · 17 comments

Comments

@tylermcginnis
Copy link
Collaborator

Example comment

lesson title: Why React?
issue: description of issue.

I'll "hide" the comment when it's fixed.

@jorgvm

This comment has been minimized.

@jorgvm
Copy link

jorgvm commented Jul 24, 2019

lesson title: "guide to react context"
issue: seems to contain the text for useMemo hook! (not mentioned in the video)
https://learn.tylermcginnis.com/courses/613356/lectures/10986166

@jorgvm
Copy link

jorgvm commented Jul 24, 2019

lesson title: "quiz react context"
issue: last question answer uses word "compasable". composable?
https://learn.tylermcginnis.com/courses/613356/lectures/10986170

@pasdo501
Copy link

pasdo501 commented Jul 24, 2019

Hey mate,

lesson title: (Quiz) Rules of Hooks
issue: Q1 (Where can you call a Hook?) has 'From the top-level of a function' as one of the expected answers. I assume (but may be very wrong) 'component' might missing from the end of that sentence?

Edit: same thing applies to (Quiz) Custom hooks

@pasdo501
Copy link

pasdo501 commented Jul 24, 2019

lesson title: (Bonus) React Render Props
issue: (minor typo) About halfway down the page, in the paragraph

The next question becomes, what should Hover render? This is where are function prop knowledge comes into play. Let’s have Hover receive a prop called render. This render prop is going to be a function that we can pass the hovering state to and it will return some UI.

Second sentence should instead be -> "This is where our function ..."

@ossan-engineer

This comment has been minimized.

@shawnstolsig

This comment has been minimized.

@shawnstolsig
Copy link

lesson title: Curriculum (starting code for the hackernoon-clone)
issue: The starting code of User.js exports class Post instead of User. Not sure if this is intentional or not...I'm guessing most students don't notice since they are refactoring to use function component anyways?

@jez321
Copy link

jez321 commented May 23, 2020

lesson title: (Project) Popular.js
issue: In the original project, error is set to null at the start of fetching to ensure the loading animation is displayed after an error occurs. This is missing from the hooks refactor, so if an error occurs during fetching, the loading animation will not be displayed on the next fetch.

https://github.com/tylermcginnis/react-hooks-course/blob/d2a040c146117aca746f7932d40092de7e3da0de/app/components/Popular.js#L92-L95

@ipovos
Copy link

ipovos commented Jul 19, 2020

lesson title: (Bonus) React Render Props
issue: missed quotation marks in expression {() => This is props.children}

@doronlinder
Copy link

Lesson title: "Wait Delay" as well as "Use Wait" (both of them, practice and solution)
Issue: Whenever "seconds" is mentioned or used in the code, it's actually milliseconds. So 3000 is 3 seconds etc.

@doronlinder
Copy link

Lesson title: (Solution) useWindowDimensions
Issue: In the solution, I think useEffect should have an empty array as the second parameter. This way the event listener is added and removed only when a component is added / removed from the DOM and not after every render.

@bobdeei
Copy link

bobdeei commented Dec 9, 2020

Lesson title: (Bonus) React Render Props
Issue: Not much of an issue, but I've seen that for many 3rd party libraries utilizing this technique, they setup both render and children for more flexibility. You may wanna include this in the article and code example as well.

I haven't watched React course to see if this bonus article match the video word by word. But something extra in the article that is not found in the video is totally fine.

@tylermcginnis
Copy link
Collaborator Author

Posts.js line 48 or so. The reducer accepts {“type”:“error”, message:string}, but the dispatch function there is passing {“type”:“error”, error:string}

@AlbertVilaCalvo
Copy link

Lesson: React.memo, useCallback, and useMemo
Issue: missing word 'out' on the text.

you need a way to opt of re-rendering expensive components

Is missing 'out' after 'opt'

@jmccraw
Copy link

jmccraw commented Feb 23, 2021

Lesson Title: (Practice) Show/Hide
Issue: Images are 404. For example, https://ui.dev/images/content/code-splitting.png

@flashbangpow
Copy link

lesson title: From IIFES to CommonJS to ES6 Modules
issue: link to "modules" (https://github.com/remix-run/react-router/tree/main/packages/react-router/modules) = 404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests