Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cancellation method for coroutines #16

Closed
abalta opened this issue Mar 29, 2020 · 1 comment
Closed

No cancellation method for coroutines #16

abalta opened this issue Mar 29, 2020 · 1 comment
Labels
question Further information is requested

Comments

@abalta
Copy link

abalta commented Mar 29, 2020

First off all, thank you for this great repository with latest Android frameworks. I noticed that there is no cancel call for coroutine scopes. Is this caused for memory leaks?

@vmadalin vmadalin added the question Further information is requested label Apr 1, 2020
@vmadalin
Copy link
Owner

vmadalin commented Apr 1, 2020

First of all, @abalta thank you for your question and you are right the project has a memory leak. It's because of the workaround implemented by google for support Navigation Component supports multiple back stacks here are the issue.

Basically the implementation is not the best and we still waiting for some android native solution to solve this. Regard the coroutines scopes I don't cancel them because I use the viewModelScope having implemented by default the close() method

override fun close() {
        coroutineContext.cancel()
}

Please let me know what do you think. Thank you :)

@vmadalin vmadalin closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants