Skip to content

auth: suport ActionCodeSettings.linkDomain #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

treitter
Copy link

This adds the ActionCodeSettings.linkDomain property to support custom domains in auth (overridding the default PROJECT_ID.firebaseapp.com authentication links).

This PR should fix issue 731.

Supported platforms:

  • android
  • ios
  • js

Unsupported platforms:

  • jvm (seems to be missing some lower-level support or I just missed the jvm dependency though it seems to just use the android one)

I haven't been able to test this since I haven't been able to resolve some issues with mavenLocal. But this is basically a copy-paste-edit of dynamicLinkDomain so it should work with, at most, trivial fixes.

@treitter
Copy link
Author

I haven't been able to test this since I haven't been able to resolve some issues with mavenLocal. But this is basically a copy-paste-edit of dynamicLinkDomain so it should work with, at most, trivial fixes.

I worked out a solution for my mavenLocal issues and confirmed success accordingly:

  • android: works
  • ios: works
  • js: untested but seems likely to work
  • jvm: unimplemented (not sure the proper way to implement)

Please let me know if there's anything I can do to help get this merged and released.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ActionCodeSettings.linkDomain to firebase-auth for all platforms
1 participant