Skip to content

Fix an issue where PDF export URLs were not bringing their query params. #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 18, 2025

Conversation

emmerich
Copy link
Contributor

@emmerich emmerich commented Jun 18, 2025

When we rewrite the URL in the middleware, we were losing the query params of the original request. This fixes that.

Here's an example of it working now: https://gitbook-v2-7p90urrx2-gitbook.vercel.app/url/gitbook.com/docs/~gitbook/pdf?page=DfnNkU49mvLe2ythHAyx&only=yes&limit=100

Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 2b209c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook-v2 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 18, 2025, 12:07 PM
customers-v2 (Inspect) 👍 Changes approved 77 changed Jun 18, 2025, 12:10 PM
default (Inspect) 👍 Changes approved 1 added Jun 18, 2025, 12:11 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 4 changed, 1 added Jun 18, 2025, 12:12 PM
v2-vercel (Inspect) 👍 Changes approved 4 changed, 1 added Jun 18, 2025, 12:12 PM

@emmerich emmerich merged commit 73e0cbb into main Jun 18, 2025
19 of 21 checks passed
@emmerich emmerich deleted the stevenh/fix-pdf-export branch June 18, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants