Skip to content

Update SpacesDropdown to manage active state based on current space #3356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

conico974
Copy link
Contributor

Pass the current space ID to the SpacesDropdownMenuItems to correctly set the active state for each item.

Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 7c35a3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 4 changed, 4 removed Jun 19, 2025, 11:14 AM
customers-v2 (Inspect) 👍 Changes approved 4 changed, 4 removed Jun 19, 2025, 11:17 AM
default (Inspect) 👍 Changes approved 5 changed Jun 19, 2025, 11:16 AM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 19, 2025, 11:18 AM
v2-vercel (Inspect) 👍 Changes approved 1 changed Jun 19, 2025, 11:20 AM

@conico974 conico974 merged commit 2dfd5aa into main Jun 19, 2025
21 checks passed
@conico974 conico974 deleted the gbo/fix-dropdown-highlight branch June 19, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants