Skip to content

Update contributing guide #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025
Merged

Update contributing guide #3381

merged 7 commits into from
Jun 24, 2025

Conversation

addisonschultz
Copy link
Contributor

Updates the readme to be more accurate and update outdated comands

Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 385769c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Jun 24, 2025, 3:39 PM
customers-v2 (Inspect) ✅ No changes detected - Jun 24, 2025, 3:41 PM
default (Inspect) 👍 Changes approved 1 changed Jun 24, 2025, 3:41 PM
v2-cloudflare (Inspect) 👍 Changes approved 4 changed Jun 24, 2025, 3:43 PM
v2-vercel (Inspect) 👍 Changes approved 1 changed Jun 24, 2025, 3:44 PM

@addisonschultz
Copy link
Contributor Author

Closes #3331

Copy link
Contributor

@talagluck talagluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having the same issues as with the last PR. I've gone through the setup steps, but I get a 404 when I try and go to http://localhost:3000/gitbook.com/docs. I also have a bunch of failures of the e2e tests ( but all of the bun commands run).

This is on the latest pull of the branch used in this PR.

@addisonschultz
Copy link
Contributor Author

@talagluck - it should be http://localhost:3000**/url/**gitbook.com/docs

Maybe this needs to be more clear in the readme?

Copy link
Contributor

@talagluck talagluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update - looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants