Skip to content

Fix ScrollSectionsList with suspended component #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

Conversation

conico974
Copy link
Contributor

Enhance the ScrollSectionsList component to work correctly with suspended components by integrating a loading state context.

Before this PR and in SSR, suspended elements could be improperly observed.

It also removes <Suspense /> in Block which can decrease the size of the RSC by up to 2Mb in some worst case scenario. (This doesn't have a big impact on user now since most page are ISR/SSG and thus Suspense won't work in these cases)

Copy link

linear bot commented Jun 24, 2025

Copy link

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: 694bae6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ✅ No changes detected - Jun 26, 2025, 10:42 AM
v2-cloudflare (Inspect) ✅ No changes detected - Jun 26, 2025, 10:46 AM
v2-vercel (Inspect) 👍 Changes approved 5 changed Jun 26, 2025, 10:42 AM

@conico974 conico974 merged commit ace6190 into main Jun 26, 2025
16 checks passed
@conico974 conico974 deleted the gbo/rnd-6340 branch June 26, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants