-
Notifications
You must be signed in to change notification settings - Fork 197
Japanese translation: Convert the toc into sequential text #818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese translation: Convert the toc into sequential text #818
Conversation
💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines. If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁
This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace. |
Thank you @rashikawat for trying to improve the discoverability of the Japanese pattern translations. The TOC is actually autogenerated programmatically. So if we want to change the order in there, we would have to change some scripts etc. Interesting idea to create a different pattern grouping. Maybe we could express that in a markmap mindmap as well, if it should not work in the TOC directly. @yuhattor could you help with this PR, as I cannot review the Japanese content that well ;) FYI I have limited internet access at the moment, so further input from me will take some weeks. |
@spier Thanks for your comment! Yes, what I wanted to do was to change the entire table of contents accordingly, since the current mind map is displayed as images and it is not possible to follow links to each pattern. So, rather than taking an approach of dynamically creating the list with a script, I decided to fix it and make it a static order for reading. |
Thanks @rashikawat for improving the readability of the Japanese TOC! This manual organization makes much more sense for sequential reading. I've added a comment to the TOC section to document this change for future maintainers:
This will help ensure that when new patterns are added, contributors know to update the manual ordering you've created. Great work on making the Japanese patterns more discoverable and easier to follow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@yuhattor @rashikawat thank you for your work on the Japanese book. I took a look at the Japanese book Your changes to the TOC may had some side-effects that were not intended. Please check the points below, and decide if you want to keep them as is or fix some of them. Breaking changes to the linksYour change means a breaking change to the Japanese pattern URLs. e.g. Btw the "p" in the URL was configured by this entry in the TOC. Really long URLsgitbook uses the title of sections in the TOC to form the URL. For some patterns you have these really long URLs now. e.g. New Japanese patterns are not automatically added to the bookBy making the TOC static, new patterns translated to Japanese will not be added to the book automatically. |
The order of the table of contents was all over the place, so I fixed it so that I could read them in order.
I also categorized each book by the main headings that were in the mind map.