-
Notifications
You must be signed in to change notification settings - Fork 726
Adding Documentation for SparkNLP Readers and Partition class #14571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some long lines need truncation and some minor things but otherwise looks good to me. Thanks!
Example 1 (Reading Text Files) | ||
---------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check if these custom headers render correctly?
@danilojsl Can you also check if these docs are accurate for your new feature? |
@paulamib123 Could you please create a new branch based on feature/SPARKNLP-1174-Adding-PartitionTransformer and add your changes there? I also recommend cloning the original spark-nlp repository directly instead of forking it. This will make it easier for us to review your changes locally and provide more effective feedback. |
@danilojsl thanks for the thorough review! @paulamib123 I also usually work on my own fork and If you rebase your changes to the newest brach it should be fine as well. |
@paulamib123 I forgot that the new feature/SPARKNLP-1174-Adding-PartitionTransformer includes the |
Closing, duplicate of #14581 |
Description
This PR adds documentation and examples for the Partition class and various document readers in spark-nlp.
Motivation and Context
Helps users understand how to use Partition and Readers to read different types of Documents.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: