maximum call stack exceeded when no width and height is sent (#14)

maximum call stack exceeded when no width and height is sent

Author: Kikobeats

index.js

@@ -2,6 +2,14 @@
 const { gcd, highestFirst, formatAspectRatio } = require('./utils')
 
 module.exports = (height, width, seperator = ':') => {
+  if (typeof height !== 'number') {
+    throw new Error(`Invalid height: ${height}`)
+  }
+
+  if (typeof width !== 'number') {
+    throw new Error(`Invalid width: ${width}`)
+  }
+
   const [h, w] = highestFirst(height, width)
   const divisor = gcd(h, w)
   return formatAspectRatio(h, w, divisor, seperator)

test/index.js

@@ -19,4 +19,34 @@ describe('aspect ratio', () => {
   it('using other separator', () => {
     should(aspectRatio(1920, 1080, '/')).equal('16/9')
   })
+
+  it('invalid width', () => {
+    let error = ''
+    try {
+      should(aspectRatio(1920, null, '/')).equal('16/9')
+    } catch (e) {
+      error = e.message
+    }
+    should(error).equal('Invalid width: null')
+  })
+
+  it('invalid height', () => {
+    let error = ''
+    try {
+      should(aspectRatio(null, 1080, '/')).equal('16/9')
+    } catch (e) {
+      error = e.message
+    }
+    should(error).equal('Invalid height: null')
+  })
+
+  it('invalid width & height', () => {
+    let error = ''
+    try {
+      should(aspectRatio(null, null)).equal('16/9')
+    } catch (e) {
+      error = e.message
+    }
+    should(error).equal('Invalid height: null')
+  })
 })