BCV renders internal declarations public if their parameter types are relocated

[sandwwraith]

There's this declaration in kotlinx-metadata:
https://github.com/JetBrains/kotlin/blob/6abf14087c46e0b5c3015eec48b92162bc63c135/libraries/kotlinx-metadata/src/kotlinx/metadata/Flag.kt#L40

It has one public constructor and two internal. 0.12.0 introduces new JAR dump mode. In this mode, constructors are getting into public dump:

 	public fun <init> (Lkotlinx/metadata/internal/metadata/deserialization/Flags$BooleanFlagField;)V
	public fun <init> (Lkotlinx/metadata/internal/metadata/deserialization/Flags$FlagField;I)V

While in 0.11.0 in regular mode they weren't there

[ilya-g]

At first sight, it may be a consequence of relocation transformation during shadowing the resulting jar.
The internal types of the internal constructor parameters are relocated, therefore changing the signature of these constructors. If the class metadata contains non-relocated signatures, BCV can fail to match them with the constructors.

I suppose the root problem is in the shadow plugin, because it corrects metadata signatures of methods after relocation, but not of the constructors.

[ilya-g]

Nevertheless the compiler still somehow matches the metadata to the corresponding constructors even if their signatures differ, so it doesn't seem to create problems for library clients, and as a result these lines in API dump look false-positively public.

So we can do the following:

• report the problem to shadow plugin and wait while it is fixed,
• find out how constructors and their metadata are matched together under these conditions by the compiler and try to do the same in BCV,
• as a workaround, annotate these constructors with an annotation that would make them explicitly non-public for BCV.

[sandwwraith]

I'm not sure shadow plugin would like to handle kotlin metadata, as they are largely language-agnostic

[qwwdfsad]

This is a bit ironic -- to make a reasonable request to preserve Kotlin metadata we need a stable kotlinx-metadata :)
It seems like the only way for now is to match metadata manually in BCV

[shanshin]

The issue was moved to YouTrack