Skip to content
This repository was archived by the owner on Jul 8, 2024. It is now read-only.
This repository was archived by the owner on Jul 8, 2024. It is now read-only.

Types overload missing for Push.Permission.request() #243

Open
Open
Types overload missing for Push.Permission.request()#243
Labels
enhancement
@Jicmou

Description

@Jicmou
Jicmou
opened on Feb 19, 2020

Push.Permission.request()can either be called with 2 callback functions as parameters, or with no parameter at all, and in that cases, returns a Promise.

index.d.ts should be updated to take the two call signatures into account.

I can make a PR to fix that.

Regards,

Activity

Jicmou
mentioned this on Feb 19, 2020
theLufenk
added
enhancement
on Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancement

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @theLufenk@Jicmou

      Issue actions
        Types overload missing for Push.Permission.request() · Issue #243 · Nickersoft/push.js