Skip to content

linked URLs #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2018
Merged

Conversation

vyaspranjal33
Copy link

@vyaspranjal33 vyaspranjal33 commented Jun 4, 2018

I've Linked Urls @nikhita

@@ -3,14 +3,14 @@ This has useful links to help you get started with contributing to open sources.

### This repository contains

1. Twitter Accounts which tweets about beginner friendly issues.
2. List of Website which curates beginner friendly issues.
1. [Twitter Accounts which tweets about beginner friendly issues](https://github.com/tapasweni-pathak/Getting-Started-With-Contributing-to-Open-Sources/blob/master/Twitter.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be shortened to just Twitter.md. It will act as a relative link and should parse correctly.

1. Twitter Accounts which tweets about beginner friendly issues.
2. List of Website which curates beginner friendly issues.
1. [Twitter Accounts which tweets about beginner friendly issues](https://github.com/tapasweni-pathak/Getting-Started-With-Contributing-to-Open-Sources/blob/master/Twitter.md)
2. [List of Website which curates beginner friendly issues](https://github.com/tapasweni-pathak/Getting-Started-With-Contributing-to-Open-Sources/blob/master/Websites.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. just Websites.md.

Copy link

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If you could update with the changes suggested, I'll merge the PR 🎉

@vyaspranjal33
Copy link
Author

please check @nikhita

@vyaspranjal33
Copy link
Author

@nikhita i am closing #7 as required changes have been made and i've opened #10

@nikhita
Copy link

nikhita commented Jun 23, 2018

@nikhita i am closing #7 as required changes have been made and i've opened #10

https://github.com/OpenSourceHelpCommunity/Getting-Started-With-Contributing-to-Open-Sources#this-repository-contains shows that other links haven't been fixed yet. This PR looks good, please make the changes and this should be good to go.

#10 just updates the first two links, so I going to close it.

@vyaspranjal33 In general, please make any related changes you want to make in the same PR only (as opposed to creating new PRs) - this helps in maintaining the context and comments. :)

@nikhita nikhita reopened this Jun 23, 2018
Copy link
Author

@vyaspranjal33 vyaspranjal33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PR can be merged now

@nikhita
Copy link

nikhita commented Aug 12, 2018

Awesome, this looks good, @vyaspranjal33! Merging! 🎉

@nikhita nikhita merged commit 7fb3f65 into OpenSourceHelpCommunity:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants