Skip to content

added iterative solution for product sum problem #11133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

added iterative solution for product sum problem #11133

wants to merge 4 commits into from

Conversation

negi153
Copy link

@negi153 negi153 commented Nov 1, 2023

Describe your change:

This contribution includes an iterative approach to solve product sum problem.
Recursion may run into Stack overflow if array has many nested arrays but iterative approach won't run into this problem.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@negi153
added iterative solution for product sum problem
21966fc 
Signed-off-by: negi153 <mukesh7758negi@gmail.com>
@negi153
Copy link
Author

negi153 commented Nov 6, 2023

@cclauss Could you or someone please review it .

@cclauss
Copy link
Member

cclauss commented Nov 6, 2023 •
edited
Loading

Please add a timeit benchmark so we can understand the performance differences between the two implementations.

@negi153
added benchmark and improved time
fe683a6 
Signed-off-by: mukeshsingh.negi@infosys.com <mukesh7758negi@gmail.com>
@negi153
Copy link
Author

negi153 commented Nov 8, 2023 •
edited
Loading

Hi @cclauss , as you suggested i have added benchmarking. Kindly take a look at this.
There is small difference in execution time but it overcomes the stack overflow problem which happen in recursion approach.

@negi153
updated variable names and doc string
79a1490 
Signed-off-by: mukeshsingh.negi@infosys.com <mukesh7758negi@gmail.com>
@negi153
Copy link
Author

negi153 commented Nov 14, 2023

Hi @cclauss any update on this ?

cclauss
cclauss reviewed Nov 25, 2023
View reviewed changes
data_structures/arrays/product_sum.py
product sum = 18 (previous) + (-13) * 6 + 8 * 6 = -12
-------------------------------------------------------

Examples:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both functions need to be tested with the SAME doctests and produce the SAME results.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss I have updated the doctest. kindly check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@negi153 @cclauss