Binary search tree #12778
Binary search tree #12778
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| The right child node. | ||
| """ | ||
|
|
||
| def __init__(self, key: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| Returns a list of keys representing the in-order traversal of the BST. | ||
| """ | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| """ | ||
| self.root = None | ||
|
|
||
| def insert(self, key: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function insert
| else: | ||
| self._insert_recursive(self.root, key) | ||
|
|
||
| def _insert_recursive(self, node: BSTNode, key: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function _insert_recursive
| else: | ||
| self._insert_recursive(node.right, key) | ||
|
|
||
| def search(self, key: int) -> BSTNode: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function search
| else: | ||
| return self._search_recursive(node.right, key) | ||
|
|
||
| def delete(self, key: int) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function delete
| """ | ||
| self.root = self._delete_recursive(self.root, key) | ||
|
|
||
| def _delete_recursive(self, node: BSTNode, key: int) -> BSTNode: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function _delete_recursive
| node.right = self._delete_recursive(node.right, temp.key) | ||
| return node | ||
|
|
||
| def _find_min(self, node: BSTNode) -> BSTNode: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function _find_min
| current = current.left | ||
| return current | ||
|
|
||
| def inorder_traversal(self) -> list: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function inorder_traversal
| self._inorder_recursive(self.root, result) | ||
| return result | ||
|
|
||
| def _inorder_recursive(self, node: BSTNode, result: list) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file tree/binary_search_tree.py, please provide doctest for the function _inorder_recursive
algorithms-keeper
bot
added
awaiting reviews
Describe your change:
Checklist: