feat(Terser): code minification migration #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to make the same changes to webpack.config.vendor.js as well |
|
@Flood Good point, I'll review and asap. |
peterblazejewicz
force-pushed
the
feat/migrate-minification
branch
from
2b4b876 to
7ff37be
Compare
This fixes webpack build in production mode See @webpack/webpack#7908 Thanks!
peterblazejewicz
force-pushed
the
feat/migrate-minification
branch
from
7ff37be to
1f3d181
Compare
|
@Flood |
peterblazejewicz
changed the title
MarkPieszak
approved these changes
Feb 10, 2019
|
Got latest and merging it in! You rock @peterblazejewicz 🎸🎸🎸🎸 |
|
YAW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes webpack build in production mode
For more details, see @webpack/webpack#7908
Thanks!