Skip to content

Webhook "members.updated" does not contain comment notification enable/disable #22858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Zeit08 opened this issue Apr 10, 2025 · 0 comments · May be fixed by #23146
Open
1 task done

Webhook "members.updated" does not contain comment notification enable/disable #22858

Zeit08 opened this issue Apr 10, 2025 · 0 comments · May be fixed by #23146
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@Zeit08
Copy link
Contributor

Zeit08 commented Apr 10, 2025

Issue Summary

Hi, I am builing some automation and my webhook members.updated triggers every time a user change it's email preference for comments (on/off). I want to handle with a if/else in my automation but the webhook data does not contain any info about comment notifications being enabled or not.
So what I have is the same webhook data for both events: user turns on comments email / user turns off comments email.

Steps to Reproduce

create webhook members.updated
login with a test member and change email preference comment toggle
you will see same data for both toggle status

Ghost Version

5.115.1

Node.js Version

.

How did you install Ghost?

.

Database type

MySQL 5.7

Browser & OS version

No response

Relevant log / error output


    
      
      
    
  


Code of Conduct


    

  •  I agree to be friendly and polite to people in this repository
    • 


      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @github-actions
github-actions
bot



          added
  the 

  needs:triage

  [triage] this needs to be triaged by the Ghost team
 label


      Apr 10, 2025

    

  



  


  
    
  
  

    
  dunknicoll 

      added a commit
        to dunknicoll/Ghost
      that referenced
      this issue

    
      May 1, 2025
    
    

      


  

    

      


  

      
        @dunknicoll
  





      

        
          🐛 Fixed missing enable_comment_notifications property in member seria…
        

          
            
          

      


      

          

    


  
    

  

    

      

        Verified
      

                

          

            
          

          

                This commit was created on GitHub.com and signed with GitHub’s verified signature.
                The key has expired.
          

        


    

    

      
    

  

  


      
        
        

            GPG key ID: 4AEE18F83AFDEB23
            

                Expired
            

            
Verified
              
            

          Learn about vigilant mode
        



      
      


      


      

          

      


      
      

        
          f236343
        
      

    

  

    

      
…lizer

closes TryGhost#22858

By adding in the `enable_comment_notifications` property into both the `serializeMember` function
and the SerializedMember type definition, this enables it to be correctly be presented in the
webhook payload.

    




    

  




  

  

    
  


  

      

    @dunknicoll
dunknicoll



    linked a pull request
    
      May 1, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  





  
  

      
        
      
      

  
    
    
  


    3 tasks
  





  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    needs:triage

  [triage] this needs to be triaged by the Ghost team








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      🐛 Fixed missing enable_comment_notifications property in member serializer

    
      dunknicoll/Ghost
    





      
    

  




      

    

  
      

  

    

      1 participant
    

    

        
          @Zeit08