Skip to content

feat(alerting): Add ilert alert provider #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

DaTiMy
Copy link

@DaTiMy DaTiMy commented Apr 22, 2025

Summary

  • Added ilert as an alerting provider
  • Added testing for ilert alerting provider
  • Added documentation

closes #1066

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
DaTiMy Tim Nguyen Van
@github-actions github-actions bot added feature New feature or request area/alerting Related to alerting labels Apr 22, 2025
@DaTiMy
Copy link
Author

DaTiMy commented May 5, 2025

@TwiN Hi, I would like to ask for a review of this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small nitpicks, but aside from that, excellent work!

DaTiMy and others added 2 commits May 16, 2025 15:36

Verified

This commit was signed with the committer’s verified signature.
DaTiMy Tim Nguyen Van

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: TwiN <twin@linux.com>
@DaTiMy
Copy link
Author

DaTiMy commented May 16, 2025

@TwiN Thank you for the review!

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a small formatting issue

Verified

This commit was signed with the committer’s verified signature.
DaTiMy Tim Nguyen Van
@TwiN
Copy link
Owner

TwiN commented Jun 5, 2025

Looks like there's a build error

Verified

This commit was signed with the committer’s verified signature.
DaTiMy Tim Nguyen Van
@DaTiMy
Copy link
Author

DaTiMy commented Jun 10, 2025

Sorry about that, should be fixed now!

@TwiN
Copy link
Owner

TwiN commented Jun 11, 2025

Looks like one of the test is failing 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(alerting): Support for ilert as alerting provider
2 participants