Skip to content

Support favicon #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mrchypark opened this issue Sep 16, 2021 · 7 comments · May be fixed by #1097
Open

Support favicon #174

mrchypark opened this issue Sep 16, 2021 · 7 comments · May be fixed by #1097
Labels
area/ui Related to the user interface feature New feature or request good first issue Good for newcomers

Comments

@mrchypark
Copy link

#77

logo feature support on 3.1.0 version. Many Thanks to your effort.

I See favicon is default when I change logo.

maybe sync with logo and favicon is expected.
@BrammyS
Copy link

BrammyS commented Oct 22, 2021

Wouldn't adding a separate UI config for the favicon be better?

@mrchypark
Copy link
Author

mrchypark commented Oct 22, 2021 •
edited
Loading

How about logo sync to favicon is default setting but can config?

@TwiN TwiN added the area/ui Related to the user interface label Jan 30, 2023
@TwiN TwiN added the feature New feature or request label Mar 29, 2023
@TwiN TwiN changed the title sync logo and favicon Support favicon Mar 29, 2023
@TwiN TwiN added the good first issue Good for newcomers label Mar 29, 2023
@TwiN
Copy link
Owner

TwiN commented Mar 29, 2023

IIRC, depending on the browser, you'll get different behavior.
For instance, the following would probably work in Firefox even if the sizes aren't accurate and regardless of what icons are configured in manifest.json:

<link rel="icon" type="image/png" sizes="256x256" href="https://twin.sh/images/logo.png"/>

However, in Chrome, the icons specified in manifest.json would probably supersede the html tag.

That being said, it would be possible to download the logo on start, and replace the default logo & png favicons here.

@TwiN TwiN pinned this issue Mar 29, 2023
@heitorPB
Copy link
Contributor

Would it be possible to have 2 favicons, one for "everything is healthy" and one for "something is not healthy"?

This way, when everything is fine the favicon is green. But when something is down, change the favicon to a different one (ideally with a yellow/red color).

@macmoritz
Copy link
Contributor

macmoritz commented Jun 27, 2023 •
edited
Loading

However, in Chrome, the icons specified in manifest.json would probably supersede the html Tag.

Is there a problem templating the manifest.json file?

Furthermore we should define <link rel="icon" ...> and <link rel="apple-touch-icon" ...>

Config example:

ui:
    icons:
        - href: icon.svg
          size: any 
          type: img/svg
        - href: icon.png
          size: 512x512
          type: img/png

size: any could be default

@macmoritz macmoritz mentioned this issue Oct 17, 2023
Open
@TwiN TwiN unpinned this issue May 10, 2024
@mehdiMj-ir
Copy link

Hello, and thank you for your app! I believe that favicon and loading are still unsupported and currently share the same image.
For those who looking to modify them, simply update your desired image and rebuild the Go binary.

Image

mloskot added a commit to mloskot/gatus that referenced this issue May 11, 2025
@mloskot
feat: Add UI configuration for custom favicon
42a3ad7 
Adds new node `favicon` to `ui` configuration
with properties that allow to overwrite the three
favicons which are currently in use in the index.html template.

Closes TwiN#174

Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
@mloskot mloskot linked a pull request May 11, 2025 that will close this issue
Open
@mloskot
Copy link
Contributor

mloskot commented May 11, 2025 •
edited
Loading

I've just proposed a simple PR for this feature request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui Related to the user interface feature New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add UI configuration for custom favicon mloskot/gatus
7 participants
@mloskot @mrchypark @heitorPB @TwiN @mehdiMj-ir @BrammyS @macmoritz