- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 520
Support favicon #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Wouldn't adding a separate UI config for the favicon be better? |
How about logo sync to favicon is default setting but can config? |
IIRC, depending on the browser, you'll get different behavior. <link rel="icon" type="image/png" sizes="256x256" href="https://twin.sh/images/logo.png"/> However, in Chrome, the icons specified in That being said, it would be possible to download the logo on start, and replace the default logo & png favicons here. |
Would it be possible to have 2 favicons, one for "everything is healthy" and one for "something is not healthy"? This way, when everything is fine the favicon is green. But when something is down, change the favicon to a different one (ideally with a yellow/red color). |
Is there a problem templating the manifest.json file? Furthermore we should define Config example: ui:
icons:
- href: icon.svg
size: any
type: img/svg
- href: icon.png
size: 512x512
type: img/png
|
Adds new node `favicon` to `ui` configuration with properties that allow to overwrite the three favicons which are currently in use in the index.html template. Closes TwiN#174 Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
I've just proposed a simple PR for this feature request |
#77
logo feature support on 3.1.0 version. Many Thanks to your effort.
I See favicon is default when I change logo.
maybe sync with logo and favicon is expected.
The text was updated successfully, but these errors were encountered: