Skip to content

RigidBodySensorComponent does not save which objects in hierarchy are enabled #5774

@TV4Fun

Description

@TV4Fun

Describe the bug
I am using RigidBodySensorComponent to report the positions and velocities of rigid bodies controlled by an agent. The sensor component correctly extracts the items in the hierarchy, but it always enables the whole hierarchy, the base of which is fixed in model space coordinates, and so just extra useless data being passed to the model. There are check boxes to disable these bodies, but they are not saved with the scene, and as soon as I start training, they are all re-enabled again. It looks like there is a settings object set to be serialized, so I'm not sure why they're not being properly trained. This also happens when I make the RigidBodySensorComponent part of a prefab and change anything there, the settings are not included with the prefab.

To Reproduce

  1. Create a GameObject with a RigidBody attached.
  2. Create several child GameObjects with their own RigidBodys.
  3. Attach a RigidBodySensorComponent to the root object.
  4. Disable some of the object's in the RigidBodySensorComponent's hierarchy settings.
  5. Save the scene, exit and reload it.
    Expected behavior: The disabled objects should be saved with the scene and persist across a save and reload.
    Actual behavior: The hierarchy always resets to the default of having all the objects enabled.

Environment (please complete the following information):

  • Unity Version: 2021.3.7f1 Apple Silicon
  • OS + version: macOS Monterey 12.5 (21G72) running on Apple Silicon
  • ML-Agents version: Latest main branch from source
  • Torch version: 1.13.0.dev20220804
  • Environment: Crawler. Try disabling one of the bodies in the RigidBodySensorComponent attached to CrawlerBase in the Platform prefab. It will not save once you have exited prefab mode.

NOTE: We are unable to help reproduce bugs with custom environments. Please attempt to reproduce your issue with one of the example environments, or provide a minimal patch to one of the environments needed to reproduce the issue.

Activity

added
bugIssue describes a potential bug in ml-agents.
on Aug 12, 2022
added a commit that references this issue on Aug 18, 2022
5e4a239
stale

stale commented on Sep 21, 2022

@stale

This issue has been automatically marked as stale because it has not had activity in the last 28 days. It will be closed in the next 14 days if no further activity occurs. Thank you for your contributions.

added
staleIssues that have been idle for a while. Automatically closed by a bot if idle for too long.
on Sep 21, 2022
stale

stale commented on Nov 2, 2022

@stale

This issue has been automatically closed because it has not had activity in the last 120 days. If this issue is still valid, please ping a maintainer. Thank you for your contributions.

github-actions

github-actions commented on Dec 2, 2022

@github-actions

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

locked as resolved and limited conversation to collaborators on Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssue describes a potential bug in ml-agents.staleIssues that have been idle for a while. Automatically closed by a bot if idle for too long.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @TV4Fun

      Issue actions

        RigidBodySensorComponent does not save which objects in hierarchy are enabled · Issue #5774 · Unity-Technologies/ml-agents