File tree Expand file tree Collapse file tree 2 files changed +4
-4
lines changed Expand file tree Collapse file tree 2 files changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -468,7 +468,7 @@ impl Collection {
468
468
self . get_config_bool ( BoolKey :: FsrsShortTermWithStepsEnabled ) ;
469
469
let fsrs_allow_short_term = if fsrs_enabled {
470
470
let params = config. fsrs_params ( ) ;
471
- if params. len ( ) = = 19 {
471
+ if params. len ( ) > = 19 {
472
472
params[ 17 ] > 0.0 && params[ 18 ] > 0.0
473
473
} else {
474
474
false
Original file line number Diff line number Diff line change @@ -116,10 +116,10 @@ impl Collection {
116
116
} ) ?;
117
117
progress_thread. join ( ) . ok ( ) ;
118
118
if let Ok ( fsrs) = FSRS :: new ( Some ( current_params) ) {
119
- let current_rmse = fsrs. evaluate ( items. clone ( ) , |_| true ) ?. rmse_bins ;
119
+ let current_log_loss = fsrs. evaluate ( items. clone ( ) , |_| true ) ?. log_loss ;
120
120
let optimized_fsrs = FSRS :: new ( Some ( & params) ) ?;
121
- let optimized_rmse = optimized_fsrs. evaluate ( items. clone ( ) , |_| true ) ?. rmse_bins ;
122
- if current_rmse <= optimized_rmse {
121
+ let optimized_log_loss = optimized_fsrs. evaluate ( items. clone ( ) , |_| true ) ?. log_loss ;
122
+ if current_log_loss <= optimized_log_loss {
123
123
if num_of_relearning_steps <= 1 {
124
124
params = current_params. to_vec ( ) ;
125
125
} else {
You can’t perform that action at this time.
0 commit comments