-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Current Behavior
https://github.com/apache/apisix/blob/master/apisix/discovery/nacos/init.lua#L354-L358
The above code logic only determines whether the MD5 value of the new data is equal to that of the data in memory, but does not verify that the new data obtained is empty.
Because if an exception occurs in the nacos service, the new data obtained may be empty, causing the data in memory to be updated incorrectly.
Expected Behavior
nacos node failure should not corrupt in-memory data
Error Logs
No response
Steps to Reproduce
- start apisix normally and configure nacos service discovery
- you need to set the nacos service as a failure while the service is running. (Note that nacos services do not require authentication)
Environment
- APISIX version (run
apisix version
): - Operating system (run
uname -a
): - OpenResty / Nginx version (run
openresty -V
ornginx -V
): - etcd version, if relevant (run
curl http://127.0.0.1:9090/v1/server_info
): - APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run
luarocks --version
):
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
Type
Projects
Status
✅ Done
Activity
github-actions commentedon May 4, 2025
This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
github-actions commentedon May 18, 2025
This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.
Baoyuantop commentedon Jun 27, 2025
fixed by #12353