Skip to content

Some bugfix in profile parsing / Better support for platforms having tools dependencies on other platforms. #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 3, 2025

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 3, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  1. Fix a profile sketch.yml rendering bug.
  2. Fix a bug that prevents extracting all the needed information in installed.json.

What is the current behavior?

  1. It will print an empty libraries: YAML object when the profile has no libraries. This is invalid YAML.
  2. If the installed platform depends on a tool from another platform, the tool metadata is not extracted in the installed.json file. This would eventually make the platform unusable if the original index is removed.

What is the new behavior?

  1. The libraries: field is not printed if there are no libraries in the profile.
  2. The installed.json now has all the necessary metadata.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

cmaglie added 5 commits July 3, 2025 14:19
This will help to simplify the next commits.
If a platform requires tools from another referenced platform, we must
extract the relevant data in the `installed.json` file too.
Just moving code, no semantic change.
Helps to get the following commit cleaner.
@cmaglie cmaglie self-assigned this Jul 3, 2025
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 3, 2025
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 95.06173% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (4891ded) to head (5e15ea3).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/arduino/cores/packageindex/index.go 94.66% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2942      +/-   ##
==========================================
+ Coverage   67.82%   67.89%   +0.07%     
==========================================
  Files         238      238              
  Lines       22460    22489      +29     
==========================================
+ Hits        15234    15270      +36     
+ Misses       6023     6019       -4     
+ Partials     1203     1200       -3     
Flag Coverage Δ
unit 67.89% <95.06%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmaglie cmaglie merged commit be841ff into arduino:master Jul 3, 2025
102 checks passed
@cmaglie cmaglie deleted the some-bugfix branch July 3, 2025 14:02
@per1234 per1234 added the topic: package-management Related to the packaging and managing of the platform/libraries label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: package-management Related to the packaging and managing of the platform/libraries type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants