Custom headers don't override the default ones #141
Description
Steps to reproduce:
- Pass a custom header to override the default one, e.g. client-request-id:
Payment.create(
new Amount("123", "EUR"),
new Pointer("IBAN", "mockiban"),
"description",
123,
null,
null,
false,
Map(
BunqHeader.CLIENT_REQUEST_ID.toString -> "123"
).toJava)
What should happen:
- The specified request header gets passed to the server, and the server recognises the Client Request ID.
What happens:
- The server doesnt recognise the passed client request ID, and doesnt deduplicate the requests. Upon further investigation, I found out that the new header value gets appended to the header key, instead of replacing it.
Traceback
SDK version and environment
- Tested on 1.14.1
- Sandbox
- Production
Response id
- Response id:
Extra info:
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Participants
Activity
Custom headers now override the default ones (bunq#141)
Merge pull request #6 from panovitch/custom-header-override-defaults
two-trick-pony-NL commentedon Mar 5, 2025
👋 Hey @panovitch
I work at bunq and am currently reviewing the bunq API docs, open issues and SDK’s and came across your issue. I know it’s been open for a while, and I’d love to understand how it’s impacting you. Beyond the obvious -fixing this issue-, what else could we do to improve your experience with our API?
If you want to share your thoughts on how we can improve on our public API:
📅 I'd love to schedule a 15 minute interview to understand your needs through: Calendly
💬 Or if you don't have time for a call, you can give us some general feedback through this form
Your feedback will go straight to our product team! 🚀
two-trick-pony-NL commentedon Apr 30, 2025
Hi! We're closing this issue as it's tied to an older version of our SDKs, and we've since completely revamped them as part of bunq Update 28.
This is a fresh start—we've tested the new SDKs extensively, and we’ll be putting them to the test again during our upcoming hackathon this Friday, where we’ll fix idiosyncrasies on the spot. (You’re welcome to join us!)
If this issue (or a new one) shows up with the updated SDKs, feel free to reopen or file a new report—we're happy to jump on it.