Skip to content

fix(crates.io): variables names #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Conversation

nuexq
Copy link
Member

@nuexq nuexq commented Apr 11, 2025

🔧 What does this fix? 🔧

fixes #1707

image

🗒 Checklist 🗒

Sorry, something went wrong.

nuexq added 2 commits April 11, 2025 21:55
@nuexq nuexq requested a review from uncenter as a code owner April 11, 2025 21:14
@github-actions github-actions bot added the crates.io crates.io label Apr 11, 2025
@nuexq nuexq changed the title fix(crates.io): update variables names fix(crates.io): variables names and hljs variables Apr 11, 2025
@uncenter
Copy link
Member

If any variables are broken, almost all are going to need to be changed (see the duplicate variables from the linter). You'll want to check every tab of every package, find all the places each variable is used.

nuexq added 4 commits April 11, 2025 22:27
@nuexq nuexq changed the title fix(crates.io): variables names and hljs variables fix(crates.io): variables names Apr 11, 2025
@nuexq nuexq marked this pull request as draft April 11, 2025 22:11
nuexq added 14 commits April 12, 2025 07:39
@nuexq nuexq marked this pull request as ready for review April 12, 2025 08:03
@nuexq nuexq requested a review from uncenter April 12, 2025 12:19
nuexq added 4 commits April 12, 2025 13:28
@MuntasirSZN
Copy link
Member

MuntasirSZN commented Jun 1, 2025

Waiting for this to be merged..... Currently turned it off.

@uncenter @nuexq Any updates?

@uncenter
Copy link
Member

uncenter commented Jun 5, 2025

@MuntasirSZN as this website randomly generates the CSS variables every time it builds, it is near impossible and consistently frustrating to keep and maintain it. This is currently pending as I decide how to handle this in the future. If you really want to move this along the most helpful thing would be to see if upstream crates.io source can adopt consistent color variables, for the base hex codes at least, making it easier here.

@uncenter uncenter added the pending Pending due to internal discussion, planned website updates, etc. label Jun 5, 2025
@uncenter
Copy link
Member

uncenter commented Jun 5, 2025

(For example looking at https://github.com/rust-lang/crates.io/tree/main/app/styles I wonder if whatever bundler is used for the CSS modules is making this difficult...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crates.io crates.io pending Pending due to internal discussion, planned website updates, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crates.io: unthemed elements
3 participants