Skip to content

Update Code to 1.100 #7329

Closed
Closed
@benz0li

Description

@benz0li
Contributor

What is your suggestion?

Update Code to 1.100

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

Activity

benz0li

benz0li commented on Apr 27, 2025

@benz0li
ContributorAuthor

Expected release date: 05/08 (this may change)

microsoft/vscode#247207

benz0li

benz0li commented on Apr 27, 2025

@benz0li
ContributorAuthor

Note to self:

  1. Check Node.js version in lib/vscode/remote/.npmrc
    • Update .node-version and package.json accordingly
  2. Check https://github.com/VSCodium/vscodium/blob/master/patches/linux/reh/s390x/arch-4-s390x-package.json.patch
sourishkrout

sourishkrout commented on May 2, 2025

@sourishkrout

As per my convo with @code-asher, Signature Verification which is in fact unsupported by OpenVSX might break for all platforms in 1.100: #7213 (comment).

benz0li

benz0li commented on May 3, 2025

@benz0li
ContributorAuthor

Note to self:

  1. Include new patch patches/signature-verification.diff
Disable signature verification.

Extension signature verification is now mandatory for all platforms and needs to be disabled.

Index: code-server/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
===================================================================
--- code-server.orig/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
+++ code-server/lib/vscode/src/vs/platform/extensionManagement/node/extensionManagementService.ts
@@ -34,6 +34,7 @@ import {
        ExtensionSignatureVerificationCode,
        computeSize,
        IAllowedExtensionsService,
+       // @ts-expect-error no-unused-variable
        VerifyExtensionSignatureConfigKey,
        shouldRequireRepositorySignatureFor,
 } from '../common/extensionManagement.js';
@@ -87,6 +88,7 @@ export class ExtensionManagementService
                @IDownloadService private downloadService: IDownloadService,
                @IInstantiationService private readonly instantiationService: IInstantiationService,
                @IFileService private readonly fileService: IFileService,
+               // @ts-expect-error no-unused-variable
                @IConfigurationService private readonly configurationService: IConfigurationService,
                @IExtensionGalleryManifestService protected readonly extensionGalleryManifestService: IExtensionGalleryManifestService,
                @IProductService productService: IProductService,
@@ -331,8 +333,7 @@ export class ExtensionManagementService
 
        private async downloadExtension(extension: IGalleryExtension, operation: InstallOperation, verifySignature: boolean, clientTargetPlatform?: TargetPlatform): Promise<{ readonly location: URI; readonly verificationStatus: ExtensionSignatureVerificationCode | undefined }> {
                if (verifySignature) {
-                       const value = this.configurationService.getValue(VerifyExtensionSignatureConfigKey);
-                       verifySignature = isBoolean(value) ? value : true;
+                       verifySignature = false;
                }
                const { location, verificationStatus } = await this.extensionsDownloader.download(extension, operation, verifySignature, clientTargetPlatform);
                const shouldRequireSignature = shouldRequireRepositorySignatureFor(extension.private, await this.extensionGalleryManifestService.getExtensionGalleryManifest());

Otherwise code-server on Linux will also error with

[...]
9.805 [2025-05-03T06:59:13.005Z] error parent:70 Uncaught exception: Signature verification was not executed.
9.805 [2025-05-03T06:59:13.006Z] error parent:70 SignatureVerificationInternal: Signature verification was not executed.
9.805     at xl.xb (file:///opt/code-server/lib/vscode/out/server-main.js:55:16152)
9.805     at async xl.wb (file:///opt/code-server/lib/vscode/out/server-main.js:55:15115)

when installing an extension.

benz0li

benz0li commented on May 3, 2025

@benz0li
ContributorAuthor

@sourishkrout You may test at https://coder.jupyter.b-data.ch/ (Image R 4.5 + Python 3.12 (jupyterlab/r/verse:test-devtools)) where code-server-4.101.0-rc.1-linux-amd64.tar.gz with Code 1.101.0 is deployed.
👉 I have whitelisted your GitHub account.

sourishkrout

sourishkrout commented on May 6, 2025

@sourishkrout

@sourishkrout You may test at https://coder.jupyter.b-data.ch/ (Image R 4.5 + Python 3.12 (jupyterlab/r/verse:test-devtools)) where code-server-4.101.0-rc.1-linux-amd64.tar.gz with Code 1.101.0 is deployed. 👉 I have whitelisted your GitHub account.

Thank you! I can confirm the patch fixes the issue described here #7213 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @sourishkrout@benz0li

      Issue actions

        Update Code to 1.100 · Issue #7329 · coder/code-server