Skip to content

CSS overriding the style of block tool SVG component #2294

Open
@siddarthvader

Description

@siddarthvader

There is a css rule in file ui.css, which goes like this...

path { stroke: currentColor; }

Now this rule is fairly innocent but when you have some SVG component as a Block tool, in my case, I am rendering Echarts as a block tool which uses SVG. Then this rules completely overtakes the styles of my svg->path element. Check this image below.


Screenshot 2023-03-03 at 6 04 03 PM

For this SVG, the stroke gets overridden by editor.js style...

Screenshot 2023-03-03 at 6 09 30 PM

This happens because SVGs style precendence works bit differently, Link

The presentation attributes thus will participate in the CSS2 cascade as if they were replaced by corresponding CSS style rules placed at the start of the author style sheet with a specificity of zero. In general, this means that the presentation attributes have lower priority than other CSS style rules specified in author style sheets or ‘style’ attributes.

There is no way to override this behaviour, So I am suggesting if ui.css style could be bit scoped, then this issue could be avoided.

Thanks in advance guys, up and up

Activity

changed the title [-]SVG->Path CSS overriding the CSS of block tool SVG component[/-] [+]CSS overriding the style of block tool SVG component[/+] on Mar 3, 2023
Vickyaryan33

Vickyaryan33 commented on Mar 16, 2023

@Vickyaryan33

I want to work on this issues please assign me this issues

siddarthvader

siddarthvader commented on Mar 16, 2023

@siddarthvader
Author

I cant assign it to you, i don't have permissions. Seems like nobody has taken notice of this :/ @Vickyaryan33

linked a pull request that will close this issue on Sep 9, 2024
Dxuian

Dxuian commented on Sep 9, 2024

@Dxuian

i believe i've managed to fix the issue pls test on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @neSpecc@siddarthvader@Vickyaryan33@Dxuian

      Issue actions

        CSS overriding the style of block tool SVG component · Issue #2294 · codex-team/editor.js