Skip to content

The no-scroll class is not given correctly  #580

Open
@wayheming

Description

@wayheming

jquery-confirm version:
v3.3.4

I'm submitting a ... (check one with "x")

  • bug report
    feature request
    support request

Current behavior:

The no-scroll class is not given correctly due to the fact that the height is incorrectly calculated. We need to use the .outerHeight() function instead of the .height() function as we do in the _updateContentMaxHeight function.
https://a.supportally.com/i/urzsk5

With .height(): https://a.supportally.com/v/iwjyIm (I can't scroll even though the content is there)
With .outerHeight(): https://a.supportally.com/v/Ay4WIg

Activity

seredniy

seredniy commented on Sep 4, 2023

@seredniy

I have this issue too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @seredniy@wayheming

      Issue actions

        The `no-scroll` class is not given correctly · Issue #580 · craftpip/jquery-confirm