Skip to content

[vm/ffi] Migrate static_checks tests from legacy multitest format #60969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samuelkchris
Copy link

Summary

Migrate FFI static_checks test files from legacy multitest format to modern static error test format using [cfe] and [analyzer] expectations.

Changes Made

  • regress_44986_test.dart: Convert Null field type error
  • regress_46085_test.dart: Convert Array annotation errors
  • regress_47673_2_test.dart: Convert unknown type error
  • regress_51041_test.dart: Convert nullable struct field error
  • vmspecific_function_callbacks_negative_test.dart: Convert callback type errors
  • vmspecific_static_checks_varargs_test.dart: Convert VarArgs errors
  • vmspecific_variance_function_checks_test.dart: Convert type variance errors

Test Plan

Converted multitest markers like //# 01: compile-time error to modern static error expectations with precise error locations and messages for both analyzer and CFE.

Fixes #60212

Migrate FFI static_checks test files from legacy multitest format to modern
static error test format using [cfe] and [analyzer] expectations.

Updated files:
- regress_44986_test.dart: Convert Null field type error
- regress_46085_test.dart: Convert Array annotation errors
- regress_47673_2_test.dart: Convert unknown type error
- regress_51041_test.dart: Convert nullable struct field error
- vmspecific_function_callbacks_negative_test.dart: Convert callback type errors
- vmspecific_static_checks_varargs_test.dart: Convert VarArgs errors
- vmspecific_variance_function_checks_test.dart: Convert type variance errors

Fixes dart-lang#60212
Copy link

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/435743

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

Copy link

https://dart-review.googlesource.com/c/sdk/+/435743 has been updated with the latest commits from this pull request.

1 similar comment
Copy link

https://dart-review.googlesource.com/c/sdk/+/435743 has been updated with the latest commits from this pull request.

@kevmoo
Copy link
Member

kevmoo commented Jun 26, 2025

Looks like tests are still failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vm/ffi] Migrate legacy multi test files
2 participants