Skip to content
This repository was archived by the owner on Apr 8, 2025. It is now read-only.
This repository was archived by the owner on Apr 8, 2025. It is now read-only.

Allow torch 1.9 version in requirements.txt #810

@vblagoje

Description

@vblagoje
Member

Hi, is there reason for torch 1.9 to be excluded from requirements.txt dependencies? These days I am working on LFQA demos on Colab which comes with torch 1.9 pre-installed. Every time I install haystack pip picks up torch<1.9,>1.5 dependency from farm and it installs 1.8.1 torch, while 1.9 is already preinstalled.

I've seen that you guys do torch compatibility testing for every new torch release. How likely are new torch releases to break farm? Would it be possible to leave upper bound on torch dependency open?

Activity

Timoeller

Timoeller commented on Jun 25, 2021

@Timoeller
Contributor

Good point. We don't mind the update.

How about we test torch 1.9 compatibility first and then increase the range? We had non obvious trouble with torch updates before.
Anyways, getting the new range into Haystack will require a new FARM release first unfortunately...

vblagoje

vblagoje commented on Jun 25, 2021

@vblagoje
MemberAuthor

Yeah, sure no problem, that sounds great! Thanks @Timoeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

questionFurther information is requested

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @vblagoje@Timoeller@julian-risch

    Issue actions

      Allow torch 1.9 version in requirements.txt · Issue #810 · deepset-ai/FARM