Skip to content

feat: Update print_streaming_chunk to work with dict version of ChoiceDeltaToolCall #9365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented May 9, 2025

Related Issues

  • fixes #issue-number

Proposed Changes:

Make print streaming chunk work with dict version of ChoiceDeltaToolCall

This allows us to use this streaming callback with the new release 3.6.0 of the BedrockChatGenerator to stream tool calls

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@sjrl sjrl self-assigned this May 9, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14929518756

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 90.37%

Files with Coverage Reduction New Missed Lines %
core/pipeline/async_pipeline.py 3 67.32%
components/generators/utils.py 8 13.64%
Totals Coverage Status
Change from base Build 14907254108: -0.05%
Covered Lines: 10914
Relevant Lines: 12077

💛 - Coveralls

@sjrl sjrl changed the title feat: Update print_streaming_chunk work with dict version of ChoiceDeltaToolCall feat: Update print_streaming_chunk to work with dict version of ChoiceDeltaToolCall May 9, 2025
@sjrl
Copy link
Contributor Author

sjrl commented May 20, 2025

Closing for now since this will change with the current work being done on the StreamingChunk

@sjrl sjrl closed this May 20, 2025
@sjrl sjrl deleted the update-print-streaming-chunk branch May 23, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants